fix: adjust missing inner content warning with svelte v5 #11380
Conversation
🦋 Changeset detectedLatest commit: cf6fbbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (basename.startsWith('+layout.') && !content.includes('<slot')) { | ||
| if ( | ||
| basename.startsWith('+layout.') && | ||
| !content.includes(isSvelte5Plus() ? '{@render children(' : '<slot') |
There was a problem hiding this comment.
This will catch {@render children(), but do we also need to catch things with different spacing?
{@render
children()
There was a problem hiding this comment.
let { children: meddlingKids } = $props();{@render meddlingKids()}
There was a problem hiding this comment.
Sorry, I didn't even think about that. I merged this too quickly.
|
This is incorrect – |
)" This reverts commit 787b739.
|
I'm reverting this for now so that we can cut a release in the meantime #11387 |
Closes #11127
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.